Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: php 8.4 #4103

Merged
merged 4 commits into from
Nov 8, 2024
Merged

test: php 8.4 #4103

merged 4 commits into from
Nov 8, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 7, 2024

Adds PHP 8.4 Compatibility (fixes deprecations)

Primarily, PHP 8.4 deprecates arguments with a null default value but no nullable type.

@SychO9 SychO9 requested a review from a team as a code owner November 7, 2024 19:12
@SychO9 SychO9 added this to the 2.0 milestone Nov 7, 2024
@SychO9 SychO9 self-assigned this Nov 7, 2024
Copy link
Member

@luceos luceos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, just wow. So many instances where nullable variables weren't properly type hinted 🙈

I left a couple of questions, hope you don't mind.

framework/core/src/Discussion/Discussion.php Show resolved Hide resolved
framework/core/src/Mail/Mailer.php Show resolved Hide resolved
framework/core/src/Mail/MutateEmail.php Outdated Show resolved Hide resolved
@SychO9 SychO9 requested a review from luceos November 8, 2024 09:03
@luceos luceos merged commit 820894a into 2.x Nov 8, 2024
28 checks passed
@luceos luceos deleted the sm/php-8.4 branch November 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants